clvk icon indicating copy to clipboard operation
clvk copied to clipboard

allow main thread to exec instead of executor when calling clFinish

Open rjodinchr opened this issue 3 years ago • 5 comments

Explicit inorder dependency between commands in order to allow main thread to steal commands from the executor when main thread reach a clFinish call. It will reduce the latency of clFinish.

extract_cmds has a boolean to extract only non-batch commands. It will be very import when clvk will be able to use timeline semaphore to manage dependencies between commands

rjodinchr avatar Sep 13 '22 17:09 rjodinchr

Do you prefer submitting yours, or should I update this one with your feedback?

rjodinchr avatar Sep 14 '22 17:09 rjodinchr

I don't feel too strongly about this. You're likely to be faster than me so if landing this quickly(ish) matters to you, it'd probably be better for you to work on it. If not, I could take a crack at it.

kpet avatar Sep 14 '22 18:09 kpet

Alright, I will submit an updated version of it in the coming days

rjodinchr avatar Sep 15 '22 08:09 rjodinchr

no regression on the full cts on swiftshader and nvidia

rjodinchr avatar Sep 15 '22 16:09 rjodinchr

no regression on the full cts with swiftshader and nvidia

rjodinchr avatar Sep 21 '22 06:09 rjodinchr

As we discussed, let's focus first on merging #424. If you want a clearer view of this PR (without the diff of #424): https://github.com/rjodinchr/clvk/pull/3

rjodinchr avatar Oct 20 '22 07:10 rjodinchr

I'll reopen one when #424 will be merged

rjodinchr avatar Nov 15 '22 12:11 rjodinchr