clvk icon indicating copy to clipboard operation
clvk copied to clipboard

clvk namespace

Open jrprice opened this issue 5 years ago • 1 comments

I'm hitting some build issues on a platform whereby some of the symbols that clvk defines in the global namespace are clashing with those defined elsewhere (e.g. string).

I'd recommend putting everything in top-level clvk namespace to avoid these sorts of issues. @kpet Would you accept a patch to do this?

jrprice avatar Nov 29 '19 20:11 jrprice

Yeah, this one was not the smartest name choice. I've pushed a change to rename it.

Yes, I'd been thinking about this, go for it. I'd rather we don't rename types and remove prefixes though, at least for now.

kpet avatar Dec 01 '19 15:12 kpet