cadabra2 icon indicating copy to clipboard operation
cadabra2 copied to clipboard

Published 20 hours ago • verified publisher icon kpeeters

USE_PYTHON_3=OFF doesn't work

Open yurivict opened this issue 7 years ago • 4 comments

It still linked to python2. I have both installed on FreeBSD. There can be many python versions installed. You should have a cmake variable which accepts the python executable, and then you should read everything else from it.

yurivict avatar Mar 31 '18 18:03 yurivict

Giving the status of python2, I am not going to spend more energy into building against that. Should probably get rid of USE_PYTHON_3 altogether.

kpeeters avatar Mar 31 '18 19:03 kpeeters

There still can be a problem in selection of python-3.5 vs. python-3.6 for example.

yurivict avatar Mar 31 '18 19:03 yurivict

It's something worth doing at some point, but requires careful testing. At the moment I am happy that the lot builds on all the various platforms; I would like to avoid introducing changes which are likely to break the build on one of them.

kpeeters avatar Mar 31 '18 19:03 kpeeters

I am not saying that this is urgent, it's rather something to keep in mind. Once you have a patch I will be happy to test it. FreeBSD might be the best platform to test it because one can easily install all possible python versions at the same time. Currently, this is a source of potential incorrectness in the FreeBSD port.

yurivict avatar Mar 31 '18 20:03 yurivict