Kevin Pedro
Kevin Pedro
assign geometry
@bapavlov some initial questions/comments: 1. Please create a companion PR to https://github.com/cms-sw/cms-bot to add your new package to `categories_map.py` 2. Is there a workflow that executes this code? If not,...
I have no strong opinion about the new package either way. To me, it is up to the DPG to decide how they want to organize their code at this...
@bapavlov just to be clear, I am waiting on your replies to https://github.com/cms-sw/cmssw/pull/47447#issuecomment-2683428273 before further review or testing.
@bapavlov indeed, if there is no new package, then no PR to cms-bot is needed. For now, you should create a new Modifier to enable this change in the DIGI...
@bapavlov also please note that the commits in the PR branch should be squashed to fix the "files with invalid states" warning sent by the bot above. There is a...
@bapavlov if you want to proceed with a new PR, that's fine (and we will close this one). but you can also just do `git push -f IRPC_RPCPhase2_squash:rpc_digi_dev_v9` to overwrite...
@bapavlov thanks, the warnings are fixed now. Once the special workflow is prepared, testing and further review can commence.
@bapavlov please follow the example suggested in https://github.com/cms-sw/cmssw/pull/47447#issuecomment-2695484089
-1 this PR cannot be approved until the new code is actually tested in a dedicated workflow, which is still pending