qr-code-styling icon indicating copy to clipboard operation
qr-code-styling copied to clipboard

Margin not working properly

Open Psycarlo opened this issue 1 year ago • 1 comments

Reproduce steps:

  1. https://qr-code-styling.com/
  2. Width: 200
  3. Height: 200
  4. Change margin one by one

It only changes around every 10-15 points.

Psycarlo avatar Jul 11 '24 00:07 Psycarlo

Maybe we could remove margin entirely so users can handle that on a outside div? So the canvas would always present the the qrcode with no margin, which means all outer points touching the border.

Maybe only to this as default because users might want margin (those who are going to download it).

Psycarlo avatar Jul 12 '24 19:07 Psycarlo

Hi @Psycarlo, It looks like a duplicate of https://github.com/kozakdenys/qr-code-styling/issues/104. You can use dotOptions.roundSize = false now. More details in https://github.com/kozakdenys/qr-code-styling/issues/104#issuecomment-1771854501 and https://github.com/kozakdenys/qr-code-styling/issues/104#issuecomment-2425170881

kozakdenys avatar Oct 20 '24 18:10 kozakdenys