qr-code-styling
qr-code-styling copied to clipboard
kozakdenys
Rotate dots
@dmitrystas this can be fixed too by the following code, it needs to be fixed in both QRSVG.ts and QRCanvas.ts:
WRONG:
dot.draw( xBeginning + i * dotSize, yBeginning + j * dotSize,
FIX:
dot.draw( yBeginning + j * dotSize, xBeginning + i * dotSize,
See fix here: https://github.com/sallandpioneers/qr-code-styling
This fork will be maintained until further notice by Salland Pioneers (business).
@dmitrystas this can be fixed too by the following code, it needs to be fixed in both QRSVG.ts and QRCanvas.ts:
WRONG:
dot.draw( xBeginning + i * dotSize, yBeginning + j * dotSize,FIX:
dot.draw( yBeginning + j * dotSize, xBeginning + i * dotSize,
@HenkVanMaanen This works for two of the styles but not the others. It's a great fix in general, but it breaks the dot designs for any design other than square and circle. This is because you are transposing them after the dots are designed. You can see this about 12 lines up.
const dot = new QRDot({ context: canvasContext, type: options.dotsOptions.type });
This is where it styles the dot. Circle and Square don't matter, but the other designs like rounded and classy are designed depending on their neighbor.
I'm trying to work through the code to see if this can be transposed earlier in the code. No luck so far understanding exactly how it works. But I'll reply when I do.
Edit: figured it out. Turns out it was only affecting the rounded and extra rounded dot styles. I'll post the fix when I'm back in the office. It's definitely a bit of a hacky fix, but it works. Im not exactly sure of what the actual issue is and why it only affects those two styles. I have a hunch of where it's broken, but I'm having a hard time understanding the canvas and SVG drawing as it's not an area I have ever worked in.
@KilianB @madmacc I do have it published but to be honest I've made other changes that I'm not comfortable other people using, only because I'm not confident I didn't introduce bugs. I have not been able to thoroughly test. I'd genuinely feel bad if I caused issues for other devs because I don't fully know if my fix is right.
with that said, if you'd like to try it out here it is: https://github.com/PlasticPrintersMN/pp-qr-code-styling you can see my fixes in the commits ahead. I still need to change the readme to reflect that this is not the original repo. Basically user beware. I'm still learning.
@NickStull Thanks, understood. I just discovered this issue and I have until the end of the week to resolve it so looking at all options!
@NickStull based on your comment above do you still think @HenkVanMaanen's version would work if just used with square style dots?
@madmacc you'll notice, after getting the dots rotation corrected it messed up the cutout for adding an image to the center. That fix is in here as well. Just to say it outloud, I'm not convinced this is the proper fix for the actual issue. There is an issue with how it's building the qr, but I digress, so far it seems to work.
@NickStull based on your comment above do you still think @HenkVanMaanen's version would work if just used with square style dots?
@madmacc yes , their fix works if using square only, but you will still need the image cutout fix if you plan to put a logo in the middle.
Another option I saw was this one: https://github.com/KilianB/styled-qr-code See: https://github.com/kozakdenys/qr-code-styling/issues/105#issuecomment-1229555378
I will update with what I end up using.
@KilianB @madmacc I do have it published but to be honest I've made other changes that I'm not comfortable other people using, only because I'm not confident I didn't introduce bugs. I have not been able to thoroughly test. I'd genuinely feel bad if I caused issues for other devs because I don't fully know if my fix is right.
with that said, if you'd like to try it out here it is: https://github.com/PlasticPrintersMN/pp-qr-code-styling you can see my fixes in the commits ahead. I still need to change the readme to reflect that this is not the original repo. Basically user beware. I'm still learning.
I have tried installing this using npm install PlasticPrintersMN/pp-qr-code-styling but it does not create the lib folder just the root files. There is a good chance I am doing something wrong as I have only every installed from www.npmjs.com before.
I did try @HenkVanMaanen's fork (npm install sallandpioneers/qr-code-styling) and this does work well with Android for a square with or without image QR code.
@KilianB's fork requires a later version of typescript than I have in my project so I can't test that.
Anyone keen on having a go at fixing this? Happy to help test but I think it is beyond me to make the fix.