datamodel-code-generator icon indicating copy to clipboard operation
datamodel-code-generator copied to clipboard

Drop support for Python 3.7

Open jorenham opened this issue 1 year ago • 13 comments

Also removed old python 3.6 code, and increased the upper bound of some deps

jorenham avatar Aug 23 '23 20:08 jorenham

The CI seems to be complaining about issues irrelevant to this particular PR.

jorenham avatar Aug 23 '23 20:08 jorenham

The failing tests can be replicated by checking out the master branch and a poetry update.

jorenham avatar Aug 23 '23 20:08 jorenham

@jorenham Thank you for creating the PR. Before we merge the PR. I want to check the active users of Python 3.7. I understand the version is EOL. But I guess some projects may use the library in Python 3.7

koxudaxi avatar Sep 07 '23 15:09 koxudaxi

I have run the cli to get the activity of this month. $ pypistats python_minor datamodel-code-generator -t -f markdown

category percent downloads
3.9 28.83% 123,761
null 23.56% 101,128
3.8 19.61% 84,168
3.10 11.75% 50,454
3.7 11.39% 48,904
3.11 4.84% 20,791
3.6 0.01% 56
3.3 0.00% 8
3.12 0.00% 3
Total 429,273

Date range: 2023-09-01 - 2023-09-24

koxudaxi avatar Sep 25 '23 14:09 koxudaxi

@koxudaxi It's rather sad to see that there are more that twice the amount of 3.7 users than 3.11...

jorenham avatar Sep 25 '23 14:09 jorenham

@jorenham

@koxudaxi It's rather sad to see that there are more that twice the amount of 3.7 users than 3.11...

This is the real world😅

We should wait for pydantic itself to drop 3.7. This is probably because pydantic is often used in the same project. https://github.com/pydantic/pydantic/pull/7188

koxudaxi avatar Sep 25 '23 14:09 koxudaxi

@koxudaxi That makes sense. I'll try again in a couple of years then 😛

jorenham avatar Sep 25 '23 14:09 jorenham

@koxudaxi https://github.com/pydantic/pydantic/pull/7188 has been merged; time flies!

jorenham avatar Nov 14 '23 12:11 jorenham

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@c298da5). Click here to learn what that means.

:exclamation: Current head 65a1669 differs from pull request most recent head 8cbb3d5. Consider uploading reports for the commit 8cbb3d5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage        ?   98.78%           
=======================================
  Files           ?       37           
  Lines           ?     4026           
  Branches        ?      938           
=======================================
  Hits            ?     3977           
  Misses          ?       36           
  Partials        ?       13           
Flag Coverage Δ
unittests 98.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 19 '23 17:11 codecov[bot]

$ pypistats python_minor datamodel-code-generator -t -f markdown

category percent downloads
3.9 28.87% 95,632
null 21.40% 70,884
3.8 18.20% 60,308
3.10 13.32% 44,143
3.7 9.83% 32,564
3.11 7.83% 25,935
3.12 0.53% 1,750
3.6 0.02% 67
3.3 0.01% 20
Total 331,303

Date range: 2023-11-01 - 2023-11-18

koxudaxi avatar Nov 19 '23 17:11 koxudaxi

0.24.* (2023/10/22~2023/11/21) image

koxudaxi avatar Nov 20 '23 17:11 koxudaxi

0.23.* (2023/10/22~2023/11/21) image

koxudaxi avatar Nov 20 '23 17:11 koxudaxi

CodSpeed Performance Report

Merging #1509 will not alter performance

Comparing jorenham:drop_py37 (8cbb3d5) with main (c298da5)

Summary

✅ 29 untouched benchmarks

codspeed-hq[bot] avatar Nov 21 '23 18:11 codspeed-hq[bot]

pypistats python_minor datamodel-code-generator -t -f markdown

| category | percent | downloads |
| :--------|-------: |---------: |
| 3.10     |  34.49% |   259,986 |
| 3.11     |  21.15% |   159,453 |
| null     |  18.45% |   139,114 |
| 3.9      |  11.02% |    83,073 |
| 3.8      |   7.09% |    53,462 |
| 3.12     |   6.52% |    49,118 |
| 3.7      |   1.27% |     9,543 |
| 3.6      |   0.00% |        37 |
| 3.13     |   0.00% |        25 |
| Total    |         |   753,811 |

Date range: 2024-06-01 - 2024-06-27

koxudaxi avatar Jun 28 '24 17:06 koxudaxi

@jorenham I want to drop support Python 3.7 but the PR needs to be updated. I'm sorry. I will close the PR and recreate a new PR for it.

koxudaxi avatar Jun 28 '24 17:06 koxudaxi