Support for mixed type arrays

Open basile-henry opened this issue 6 years ago • 1 comments

Currently tomland disallows mixed type in TOML arrays. From the documentation for the Value constructor Array:

https://github.com/kowainik/tomland/blob/d9b7a1dc344e41466788fe00d0ea016f04629ade/src/Toml/Type/Value.hs#L172-L185

This seems to be in line with all the previous versions of the TOML specification, however it was recently changed in https://github.com/toml-lang/toml/pull/676

Updating tomland to the latest version of the spec is probably quite involved, and would likely change the user facing API. The Value type being a GADT is most likely only to ensure that this invariant around arrays is held.

I am opening this issue to simply ask if there are any plans to support this new feature? And if so, if you need any help implementing it! :smile:

Nov 13 '19 18:11 basile-henry

Hey @basile-henry , thanks for the report! We are supporting the current version of the TOML specs — TOML-0.5.0. What you are talking about are unreleased changes in the master branch. It is still not confirmed that it is going to be in the next release and the date of the major upgrade could be too far away to spoil the library with unsupported changes.

Thanks for letting us know, but again I wouldn't be in a hurry to support such huge and not thought-through changes. Let's decide the future of the tomland when the time comes.

Nov 13 '19 19:11 vrom911