summoner icon indicating copy to clipboard operation
summoner copied to clipboard

Add support for summoning GHC 9.2.8, 9.4.5, and 9.6.2

Open noughtmare opened this issue 1 year ago • 23 comments

I've also updated the latest Stackage snapshots of 8.10.7 and 9.0.2.

noughtmare avatar Jun 18 '23 14:06 noughtmare

@willbasky I've implemented your suggestion, thanks.

@vrom911 can you please review this?

noughtmare avatar Aug 10 '23 08:08 noughtmare

@noughtmare The tests need the updates.

willbasky avatar Aug 10 '23 11:08 willbasky

I've used gg to update the golden tests.

noughtmare avatar Aug 10 '23 12:08 noughtmare

What a nice tool!

willbasky avatar Aug 10 '23 12:08 willbasky

It seems the CI also needed updating.

noughtmare avatar Aug 10 '23 12:08 noughtmare

Oh, of course summoner itself doesn't build on 9.6.2

noughtmare avatar Aug 10 '23 13:08 noughtmare

And that's blocked on shellmet, at least.

noughtmare avatar Aug 10 '23 13:08 noughtmare

Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.6.2.0 supports 'ghc' version < 9.4): /home/runner/.ghcup/bin/ghc is version 9.6.2

< 9.4 yes, building summoner with 9.4.5 and 9.6.2 has no ways right now.

Also, instead of 9.2.4 we could build on 9.2.8

willbasky avatar Aug 10 '23 15:08 willbasky

But if we can't build on 9.4.5 and 9.6.2 then we also can't test if summoning those versions work, except perhaps if we would build summoner with a different version of GHC than what we use to test the summoned project.

noughtmare avatar Aug 10 '23 16:08 noughtmare

Do the golden tests check if the 'project that is made with specific ghc in configs' is built with that ghc? In other words:

  1. Summoner makes project with ghc version X.
  2. Tests tried to build made project. Is it?

willbasky avatar Aug 10 '23 16:08 willbasky

I think you're right that the tests only check things like 1, but then I don't understand why it did not work before I changed the CI. I'll revert that and we can try again.

noughtmare avatar Aug 10 '23 17:08 noughtmare

Neat, the old results are still here.

Ah, so it's actually a separate CI action that tries to build the minimal project.

noughtmare avatar Aug 10 '23 17:08 noughtmare

If checks within 9.6.2 will pass then we could left checks for 9.4.5 too

willbasky avatar Aug 10 '23 17:08 willbasky

I've now added 9.4.5 too

noughtmare avatar Aug 10 '23 17:08 noughtmare

Now it should work...

noughtmare avatar Aug 10 '23 21:08 noughtmare

I've squashed the commits

noughtmare avatar Aug 10 '23 21:08 noughtmare

https://discourse.haskell.org/t/ghc-9-4-6-is-now-available/7231 I am sorry :))

willbasky avatar Aug 12 '23 00:08 willbasky

@willbasky there will be a 9.4.7 soon, so I think we should skip 9.4.6.

noughtmare avatar Aug 12 '23 08:08 noughtmare

Hi, GHC 9.4.7 is now available, and slated to be the final release of the 9.4 series. Anything blocking this from merging?

Vekhir avatar Sep 12 '23 13:09 Vekhir

@kowainik @vrom911 @noughtmare @willbasky What is the plan to proceed with this PR to enable summoner to support GHC 9.2, 9.4, and 9.6? GHC 9.4.7 has been released, together with a new release 9.6.3.

A new version of summoner on Hackage would also be much appreciated, as it's needed for the Arch package

Vekhir avatar Oct 07 '23 02:10 Vekhir

@Vekhir I think this package has been abandoned. I'm personally not motivated enough to fork and initiate the package takeover process. So I think not much is going to change any time soon.

noughtmare avatar Oct 07 '23 10:10 noughtmare

Alright, thanks for your reply.

Vekhir avatar Oct 07 '23 11:10 Vekhir

@Vekhir Hi, I tried to message to @vrom911 in social media she didn't answer. As for me I haven't the right to merge here anything without second approval I guess. I am sorry.

willbasky avatar Oct 07 '23 12:10 willbasky