hintman icon indicating copy to clipboard operation
hintman copied to clipboard
verified publisher icon kowainik

Deal with multiline hints

Open vrom911 opened this issue 6 years ago • 2 comments

vrom911 avatar Aug 25 '19 13:08 vrom911

Currently, we put a simple comment (not a suggestion) on the last line of the multiline hint (if it's in the range of the diff). Probably we should consider not only the last line but any, which satisfies the diff?

vrom911 avatar Oct 07 '19 15:10 vrom911

@vrom911 We can use new GitHub feature for multiline comments to select the whole area. But:

  1. This is more complicated because it requires more interval and range overlapping checks.
  2. This feature is in beta now, I'm not even sure there's an API for it...

Commenting on the last line seems good enough for now to me :slightly_smiling_face:

chshersh avatar Oct 07 '19 15:10 chshersh