hintman [RFC] How to review the same PR again?

Currently, Hintman reviews PRs when they are open. But sometimes it might be desired to rereview them again. It's possible to handle request_review action for Hintman and review again. But the question, what parts should we review again?

Oct 08 '19 18:10 chshersh

I would say that the whole diff from the master branch if it's possible to collapse at once in the API...

Oct 08 '19 19:10 vrom911

@vrom911 I agree that the whole diff from master should be reviewed again, even if some suggestions are going to be duplicated. Keeping track of previous suggestions is extremely difficult and it's a stateful computation we would like to avoid... Also, with all these rebases and force pushes it's merely impossible. API gives exactly the hash of the last commit in PR, so re-reviewing the whole diff is also easier :smile:

Oct 08 '19 19:10 chshersh

Another question: should hintman be triggered on Reopened PRs? Or should we make it configurable with disabled by default to not annoy people?

Oct 20 '19 12:10 chshersh

Maybe it only should be triggered on newly opened PRs or on explicit demand (this request the review button near the reviewer's icon), what do you think?

Oct 21 '19 08:10 vrom911

@vrom911 Makes sense. Let's trigger only on opened PRs and on the explicit request. Unfortunately, with GitHub UI it's very easy to accidentally close and reopen PR.

Oct 21 '19 08:10 chshersh