mark icon indicating copy to clipboard operation
mark copied to clipboard

Fix for relative links

Open jack-fireworkhq opened this issue 2 years ago • 4 comments

Hi Kovetskiy, First of all, thank you for creating this great repo.

I have done some effort to resolve kovetskiy/mark#55, I think the main cause for this is here which makes Mark failed to find relative links. I fixed it with code here.

Besides that, I add a "-L" option so that Mark can take many files at the same time as input. I did that to let users be able to synchronize files references with relative links to each other. I add a loop here to retry resolve relative links after everything was synchronized to Confluence once.

I tested this with the Github action I forked and modified it, and Mark works as my expectation. Leave some comments if you feel some code needs to be changed.

PS: This JackTheMico is my personal account, I guess there is a misconfiguration of my git :smile: .

jack-fireworkhq avatar Apr 29 '22 03:04 jack-fireworkhq

I had the problem with relative links I made a quick test (confluence cloud 1000.0.0-a50a53c8c11e) and it solved the proble for me (the links were not recognized/displayed by confluence)

Thanks to all of you for your work and help

kertechs avatar May 17 '22 15:05 kertechs

@jack-fireworkhq , @kertechs is this PR good to be merged ?

adrianrussell avatar Dec 12 '22 02:12 adrianrussell

@jack-fireworkhq , @kertechs is this PR good to be merged ?

It works for me and my team. I'd recommend you try it first before merging it

jack-fireworkhq avatar Dec 14 '22 02:12 jack-fireworkhq

I'd be eager to have this feature merged

nyarly avatar Jan 09 '23 19:01 nyarly