Incorrect handling of unpaired surrogates in JS strings

[Pauan]

It was brought to my attention in https://github.com/Pauan/rust-dominator/issues/10 that JavaScript strings (and DOMString) allow for unpaired surrogates.

When using TextEncoder, it will convert those unpaired surrogates into U+FFFD (the replacement character). According to the Unicode spec, this is correct behavior.

The issue is that because the unpaired surrogates are replaced, this is lossy, and that lossiness can cause serious issues.

You can read the above dominator bug report for the nitty gritty details, but the summary is that with <input> fields (and probably other things), it will send two input events, one for each surrogate.

When the first event arrives, the surrogate is unpaired, so because the string is immediately sent to Rust, the unpaired surrogate is converted into the replacement character.

Then the second event arrives, and the surrogate is still unpaired (because the first half was replaced), so the second half also gets replaced with the replacement character.

This has a lot of very deep implications, including for international languages (e.g. Chinese).

I don't see any easy solutions for stdweb, since it always converts JS strings into Rust Strings. This is different from wasm-bindgen which has a separate JsString type (which is specifically for JS strings).

[Pauan]

(wasm-bindgen also suffers from this issue, here is the bug report: https://github.com/rustwasm/wasm-bindgen/issues/1348 )