Sutou Kouhei
Sutou Kouhei
https://github.com/clear-code/rurema-search/blob/2697320aa5044b6dd5d0e2b35ababbd735a0291b/lib/rurema_search/groonga_searcher.rb#L125 で`@request.url`を使っているのを`X-Forwareded-XXX`があったらそいつらを優先するようにすればいいという感じですか?
> Can we use this feature on `ruby/ruby` repo? No. > If It's No, we skip this test at `ruby/ruby` repo. Right. > I'm happy to port this feature to...
I think that we don't need to suppress the Ractor warning. So test-unit doesn't suppress the warning automatically. If we should suppress the Ractor warning, I'll do it in test-unit.
I see. test-unit shows `omit` messages by default but doesn't show such messages by default on GitHub Actions: https://github.com/test-unit/test-unit/blob/d4183f6688fa8bc83566224aaaf66c51f8434bae/lib/test/unit/ui/console/testrunner.rb#L538-L539 So I'll change test-unit to suppress the Ractor warning by default...
How about adding `Datasets::CSVParser` like `Datasets::ZipExtractor` and extending `Datasets::CSVParser` in `red-datasets-arrow`?
Proposal 2 isn't acceptable. We should put all files under `datasets/` to avoid conflict. I don't like `common`. If we use `datasets/common/`, `Datasets::Error` should be renamed to `Datasets::Common::Error`, right? `Datasets::Common::Error`...
Thanks. It seems that the following test is the slowest test: ```text QuoraDuplicateQuestionPairTest: test: #each: .: (22.387830) ``` Let's look into this as the first step.
Why? I think that macOS and Windows don't follow XDG. If we want to change cache directory for Red Datasets, we should introduce our environment variable such as `RED_DATASETS_CACHE_DIR` or...
Do you know products that use XDG on Windows/macOS? If there are many products, we can follow it. Otherwise, we should introduce an environment variable only for us.
Do you have any idea? What should we care about it? Local storage size? Download time? ...?