jquery-circle-progress icon indicating copy to clipboard operation
jquery-circle-progress copied to clipboard

Introduce `emptyThickness` parameter

Open monovertex opened this issue 8 years ago • 7 comments

This PR fixes #164.

Adding the emptyThickness parameter caused some issues when the empty arc was thicker than the full one (the empty arc had parts rendered outside the canvas), so I had to rewrite the arc rendering logic a bit, in order to use the max thickness between the two arcs.

Furthermore, thicker empty arcs also required the full empty circle to be rendered, not only the empty part itself.

I added a new example for the different thickness parameters, but I placed it before the heavily customized circle, even though it comes after it as number 6.

Finally, I added several tests for the new functionality and fixed one that was failing on my laptop.

monovertex avatar Sep 12 '17 12:09 monovertex

@monovertex - do you agree with my recent remarks?

kottenator avatar Sep 28 '17 17:09 kottenator

@kottenator Yes I do. I apologize for the delay, it's been a few really busy days at work. I'll fix the required changes as soon as possible.

monovertex avatar Sep 28 '17 17:09 monovertex

Great, I'm looking forward for it ;) And take your time, nobody is rushing, it's OSS.

kottenator avatar Sep 28 '17 20:09 kottenator

@monovertex - ping? ;)

kottenator avatar Dec 03 '17 17:12 kottenator

@kottenator, I'm sorry for the really late update. Things got hectic IRL and I haven't had the time or energy to focus on anything else. Let me know if there are any other improvements you'd like me to make to this PR.

monovertex avatar Dec 04 '17 12:12 monovertex

@kottenator, ping?

monovertex avatar Aug 01 '18 05:08 monovertex

@kottenator, coming back for one more ping, hope you see this some day. Thank you!

monovertex avatar Apr 21 '20 08:04 monovertex