jquery-circle-progress icon indicating copy to clipboard operation
jquery-circle-progress copied to clipboard

Different thickness for empty arc

Open monovertex opened this issue 8 years ago • 5 comments

Would it be possible to have a different thickness for the empty arc behind the filled one?

From an initial look at the code, it should be trivial to add a new parameter that defaults to thickness if not specified.

I can submit a PR if there's no potential blocker with this proposal. Are there any contribution guidelines?

monovertex avatar Aug 29 '17 08:08 monovertex

@monovertex - there was a discussion 2 years ago - #24. At that time I didn't have chance to implement it. But I've provided a snippet (which is more a workaround, though).

Feel free to create a pull-request. But don't forget to add corresponding tests ;)

BTW, I have the whole gallery of snippets with various custom things.

kottenator avatar Aug 30 '17 15:08 kottenator

@kottenator: Thanks for the input and guidelines. I'm on it and an initial implementation is already ready. Got some stuff to iron out for when emptyThickness is larger than thickness and do the tests and then I'll open a PR.

You can assign this to me, if you want.

monovertex avatar Sep 01 '17 08:09 monovertex

@monovertex - I think your PR is almost fine, but I have one important remark there. Please, take a look.

kottenator avatar Sep 25 '17 14:09 kottenator

@kottenator: I'm all open for feedback, but there's no comment on the PR. Could you let me know if something went wrong or where could I see that remark?

monovertex avatar Sep 25 '17 14:09 monovertex

Sorry, my mistake - I'm new to GH reviews, I didn't publish it. Check now.

kottenator avatar Sep 25 '17 14:09 kottenator