Krzysztof Kotowicz
Krzysztof Kotowicz
I changed the plugin to appear as a lib (prevously it was an export storage plugin), cleaning up the UI, adding more descriptions, tooltips, and exposing preferences. I also added...
I fixed the crash, thanks! And many other errors that are obvious when running the plugin on a clean profile 😅 When generating UltraHDRs with gainmaps as inputs, the [`metadata.cfg`...
No worries @wpferguson, I'm not pressed for time here. I am using this plugin already and consider it stable-enough (there's no bugs I'm aware of), though obviously it's hard to...
> Did some testing... > > When I test I clone the latest copy of darktable master and compile it. I pull the latest master from the lua scripts. Then...
Yes, `-L` was added in 1.3.0 in https://github.com/google/libultrahdr/commit/e432c4d93ded76d0eaead27b9e4636a85e67672b. FWIW, nowadays libultrahdr is [available directly through packages](https://repology.org/project/libultrahdr/versions) on some distros, and 1.3.0 bundles `ultrahdr_app` IIUC,
One potential culprit might be https://github.com/darktable-org/lua-scripts/pull/502/files#diff-964234d8155307277adf239627f3dc0d579d0c2b6669adb192e3d168cc3a9e17R419-R420, I remember some gboolean change wasn't completed in DT, there was some pending work. The symptoms would be indeed that a temporary file is...
My hunch was correct - it's https://github.com/darktable-org/darktable/issues/17528. I'll update the PR with the new logging code and an updated workaround condition. In 9.3.0 and 9.4.0, I'll treat `::write_image` returning false...
With the workaround code I can now generate UltraHDRs with the same reproduction steps on 4.9.0+1181~gfa54963782-dirty (still MacOS).
Done. The workaround for write_image return value is now only applied in 9.3.0.
I don't see any review comments in the PR, did you mean the changes with the log levels in each function? These are already in.