Docking branch available for testing

[elect86]

The docking branch has been ported, it's based on the last 1.77

https://user-images.githubusercontent.com/8225057/46300244-80708900-c5a3-11e8-8365-f89cfd06080e.gif

Known bug: problems by loading properly the windows position from the ini file

Original issue

I'll be glad to gather feedbacks

[zeroeightysix]

On linux, using the GNOME DE, running on wayland:

• [x] With the ini file present, all windows spawn on the bottom right of the screen (video 1)
• [x] Many actions will result in the same JVM crash (crash) (video 1 and video 2)
  • Returning a undocked window back to the main window
  • Closing a undocked window
  • Rarely, opening a undocked window (I've only had this happen with context menus)
• [ ] The native 'closing animation' is visible, creating a non-seamless transition from undocked -> docked. (video 1)
• [ ] Dragging a docked window out of the main window will undock it, but will also stop dragging the window (video 2)
• [x] About 1 in 5 tries, instead of a JVM crash, the message *** buffer overflow detected ***: terminated appears. (video 3)

Here's a list of JVM crashes I ran into while testing. They appear to all be more or less the same, but most have a slightly different call stack.

[elect86]

Thanks for the list

ini bug fixed

I had a couple of commit still locals, could you give a try to the rest?

Most of the stuff looks fine on Win, I'm gonna update Ubuntu in the meanwhile :p

[elect86]

I don't experience your crashes.

I can replicate n4, the dragging issue

Ubuntu 19.04

[zeroeightysix]

Are you running a wayland or xorg session? On the login screen, as I recall, there should be a button on the bottom right that allows you to choose which session to log into. The crashes I experience are on wayland (with XWayland enabled, but that should be on by default).

For the latest commits, I actually can't run the docking branch anymore:

Exception in thread "main" java.lang.NoSuchFieldError: DockingEnable
	at examples.ImGuiOpenGL3.<init>(opengl3.kt:92)
	at examples.Opengl3Kt.main(opengl3.kt:30)
	at examples.Opengl3Kt.main(opengl3.kt)

Not sure why this happens. IDEA is able to navigate to DockingEnable just fine. A (black) window will spawn and shortly after close with the above error message.

[elect86]

The default, xorg

Try deleting the cache and rebuild

[zeroeightysix]

The default, xorg

Can you try on wayland instead?

Try deleting the cache and rebuild

This worked - but all previous bugs (aside from ini thing) are still there.

[elect86]

Sure, I tried right now

no crashes bringing windows inside/outside my main window (the drag issue still there though).

I'm on Ubuntu 19.10 and Intel UHD Graphics 620 (nuc)

Which distro and gpu are you using?

[zeroeightysix]

I'm using Arch linux with vanilla GNOME. I have an i5-8250U with integrated graphics. (no dedicated GPU)

[elect86]

@zeroeightysix

Spasi

Currently, the choice between X11 and Wayland cannot be made at runtime, GLFW must be built to support one or the other. That's why lwjgl-glfw-natives-linux.jar includes two binaries. LWJGL defaults to X11. You can use -Dorg.lwjgl.glfw.libname=glfw_wayland (or call Configuration.GLFW_LIBRARY_NAME.set("glfw_wayland") before initializing GLFW) to enable the shared library that supports Wayland.

[zeroeightysix]

Running with the wayland flag causes the following error: /usr/lib/jvm/java-11-openjdk/bin/java: symbol lookup error: /tmp/lwjglridan/3.2.3-build-13/libglfw_wayland.so: undefined symbol: __wrap_memcpy

Presumably related to https://github.com/LWJGL/lwjgl3/issues/543 or https://github.com/LWJGL/lwjgl3/issues/557?

However, I tried launching again (without the wayland flag, making it fall back to XWayland) and the JVM crashes are gone! I have no clue why, but I'm not going to question it either. Problem 3 and 4 (native animation, dragging) persist.

[zeroeightysix]

• [ ] Windows run away when docked. (video)