pygooglenews icon indicating copy to clipboard operation
pygooglenews copied to clipboard

Upgrade feedparser

Open 8W9aG opened this issue 3 years ago • 4 comments

  • Currently the feedparser specified in the requirements does not work with Python 3.9.x due to this issue: https://github.com/kurtmckee/feedparser/pull/206
  • Upgrade the feedparser so pygooglenews works with python 3.9.x

8W9aG avatar May 30 '21 08:05 8W9aG

  • Currently the feedparser specified in the requirements does not work with Python 3.9.x due to this issue: kurtmckee/feedparser#206
  • Upgrade the feedparser so pygooglenews works with python 3.9.x
  • Currently the feedparser specified in the requirements does not work with Python 3.9.x due to this issue: kurtmckee/feedparser#206
  • Upgrade the feedparser so pygooglenews works with python 3.9.x

Line 93 in feedparser.py change _base64decode = getattr(base64, 'decodebytes', base64.decodestring) to base64.decodebytes. This is based on the fix by @kurtmckee

decorouz avatar May 30 '21 18:05 decorouz

Thanks for the approval, cannot merge myself due to permissions

8W9aG avatar Aug 15 '21 22:08 8W9aG

I know just trying to spam the notifications enough to get the owner to notice :P

Pyth3rEx avatar Aug 16 '21 17:08 Pyth3rEx

To anyone who wants to use this lib but can't install, you can force the dependencies to be a specific version this way:

python -m pip install "beautifulsoup4==4.9.1"
python -m pip install "dateparser==0.7.6"
python -m pip install "requests==2.24.0"
python -m pip install "feedparser==6.0.8"
python -m pip install --no-deps pygooglenews

This should work. (If it doesn't, check if the versions have changed in pyproject.toml for some reason)

NicolasCaousGV avatar Jan 29 '22 16:01 NicolasCaousGV