Kostya M

Results 147 comments of Kostya M

so 0.8.celluloid15 works fine for long, and 0.8 have problems after some hours (on ruby 2.3.0)? diff between this versions is only https://github.com/kostya/eye/compare/v0.8.celluloid15?expand=1 (updated celluloid version) may be you can...

1. `trigger :flapping, :times => 10, :within => 1.minute, :retry_in => 1.hour` ? 2. show config example where flapping not working with dependency.

``` # Nokogiri (1.6.6.2) --- warnings: [] nokogiri: 1.6.6.2 ruby: version: 2.2.0 platform: x86_64-darwin13 description: ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin13] engine: ruby libxml: binding: extension source: packaged libxml2_path: "/Users/kostya/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/nokogiri-1.6.6.2/ports/x86_64-apple-darwin13.0.0/libxml2/2.9.2"...

doc not updated, why not, i think its ok, if you want special format you set it.

this not single possible variant, you can do many things: ```crystal require "./src/msgpack" msg = Time.now.to_msgpack(Time::Format.new("%F")) p msg p String.from_msgpack(msg) time = Time.from_msgpack(Time::Format.new("%F"), msg) p time class A include MessagePack::Serializable...

```crystal struct UnixConverter def self.from_msgpack(unpacker) Time.unix_ms(unpacker.read_int) end def self.to_msgpack(value, packer) packer.write(value.to_unix_ms) end end msg = Time.now.to_unix_ms.to_msgpack p msg p Int64.from_msgpack(msg) p UnixConverter.from_msgpack(MessagePack::IOUnpacker.new(msg)) class B include MessagePack::Serializable @[MessagePack::Field(converter: UnixConverter)] property value...

may be unix by default would be better, i just choose the same as json converter.

i not sure that default need to be deleted, at least you can redefine default also: ```crystal require "msgpack" struct Time def to_msgpack(packer : MessagePack::Packer) packer.write(self.to_unix) end def self.new(pull :...

this is issue for simple_rpc, also this is quite hard, because type can have subtypes, or array of subtypes, and inspect it property is not easy.

you can add custom time serialization for ext: example: https://github.com/crystal-community/msgpack-crystal/blob/master/examples/ext.cr, not sure it should be by default