Kostis (Codefresh)

Can you explain a bit your use case and what you are trying to do? > Revert previewReplicaCount and update replicas Why do you need to revert previewReplicaCount? Why not...

> The goal is just to not have anything impact the blue/active deployment until it has gone through green/preview. Sorry, I still don't understand why this requirement is not covered...

From the log that you posted `level=warning msg="Error create apisix route \"set-header\": apisixroutes.apisix.apache.org is forbidden: User \"system:serviceaccount:argo-rollouts:argo-rollouts\" cannot create resource \"apisixroutes\" in API group \"apisix.apache.org\" in the namespace \"default\"" event_reason=ApisixRouteCreateError...

So it worked just fine with 0.5.0? Also what is your version or Argo Rollouts? Please also look at https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/issues/29

Argo Rollouts is already at 0.32.0 https://github.com/argoproj/argo-rollouts/blob/master/go.mod#L203 So is this report still valid?

Yes I think your assumption is correct. Did you take a look at the controller logs for this rollout? Was there an error message?

It would be great if there was a full example at https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/tree/main/examples that people can test and compare behavior with/without this PR implemented.

@zachaller the code duplication (SonarCloud) is in the unit tests. Let me know if this is indeed a problem or not.

Hey Doesn't version 0.2.0 of the plugin work with Linkerd? Or you are missing some features that have since been added to the plugin and you want to use them...

There are several big organizations that use argo rollouts WITHOUT argo cd. The two projects are completely independent I would just open an issue to argo cd instead for locating...