Vladimir Grenaderov

Results 47 comments of Vladimir Grenaderov

It's a c8 issue - all incoming urls transformed into paths `fileURLToPath`: https://github.com/bcoe/c8/blob/a13584d5be5259ebb6a00455d352c3e8b16006de/lib/report.js#L364 As a result, 'dep.js?mocked-by-esmock' transformed into 'dep.js' which leads to parasitic coverage for real 'dep.js. Because c8...

> Looking at this from c8's perspective, I'm not sure how else to interpret `file.js?querystring` other than to strip the query string. At first, let's talk about file urls. From...

> Are they different modules or just different instances of the same module? Yeah, different spec == different module.

> I was running into this with c8+ava as well I suggest you to simplify that script a bit. Coverage collected by Node, so you only need to set environment...

@brockross it much easier to use small patch - https://github.com/istanbuljs/v8-to-istanbul/issues/198#issuecomment-1310007608. no any issues in very large (8000+ tests) repo since nov'22

> yarn is very convenient, but it makes it easy to forget adding the dependencies when everything runs as expected Just enable Yarn PnP and you will see all possible...

@arcanis what do you think about that issue? It's not a blocker but really annoying issue which doesn't allow to use corepack + ESM packages in yarn.config.cjs (nice feature allows...

@aduh95 it's a good idea. As far I understand, corepack shipped with node is a bundle (dist/lib/corepack.cjs) and contains all v8-compile-cache code. So, IF fix will work (how to test...

> require [nodejs/node#51244](https://github.com/nodejs/node/pull/51244) to land first Landed. What is our next steps - to fix https://github.com/zertosh/v8-compile-cache/pull/47 or to create new one? I can't help so much with coding, but I...