djv icon indicating copy to clipboard operation
djv copied to clipboard

Sync Test suite with json-schema-benchmark

Open korzio opened this issue 5 years ago • 3 comments

  1. Ensure test suite is equal to the one used inside the https://github.com/ebdrup/json-schema-benchmark/ repository . Currently https://github.com/json-schema-org/JSON-Schema-Test-Suite is a git dependency inside package.json for the djv project. Inside the https://github.com/ebdrup/json-schema-benchmark/ it is used in a different way - as a git sub module.
  • Hint - use https://github.com/ebdrup/json-schema-benchmark/blob/master/README.md as an single point of truth
  1. Fix tests is some are failing
  2. Understand how the update of benchmark will happen, both in benchmark and djv repository. They should be synced

korzio avatar Nov 22 '19 16:11 korzio

Dear @ebdrup

We see that in the json-schema-benchmark repository you use a git submodule for JSON-Schema-Test-Suite dependency. We see in the github a link to the commit with the SHA 86f965e53dda0b6c57e70ddd726243e1e061cf84 , but we cannot find any reference in the codebase about this specific commit. We also see that the latest "tagged" version of JSON-Schema-Test-Suite is https://github.com/json-schema-org/JSON-Schema-Test-Suite/commits/2.0.0 and for now djv is compliant with it. But we'd like to go further and adopt latest tests and start working on updated suites. So, our questions are:

  • Where can we find a link to the specific JSON-Schema-Test-Suite commit in the json-schema-benchmark project?
  • What would be the best strategy to run djv tests against? Should it be master branch of the JSON-Schema-Test-Suite repository?

I hope you can point us to the right direction, otherwise please let me know who else can help :) Thanks in advance

korzio avatar Nov 29 '19 17:11 korzio

https://github.com/korzio/djv/pull/92

korzio avatar Dec 07 '19 13:12 korzio

  • [ ] Test https://github.com/korzio/djv/pull/92 with 86f965e53dda0b6c57e70ddd726243e1e061cf84 json-schema-benchmark
  • [ ] Check performance before @openself last commit and after https://github.com/korzio/djv/pull/92
  • [ ] Test other validator refactoring
  • [ ] Make decision

korzio avatar Dec 07 '19 13:12 korzio