gospel
gospel copied to clipboard
Update deps to avoid panic in packages lib
When built using newer Go (1.22.0), gospel
would panic deep inside golang.org/x/tools/go/packages
. After binary-searching which of the packages.Config{Mode}
flags triggered it, I tried a package update of the package rather than see if that Need was truly needed.
And that upgrade fixed things.
So update all dependencies to current (in case there are config deserialiser security vulns, etc) and things still work.
(Also, .gitignore the binary name)
PR-only text:
I see two test failures:
- TestScripts/suggestions in
expected_noshow_suggest_one
- My OS's hunspell dictionary adds "couriered" as a suggested fix for "coloured". Ignoring this as a testing environment variance
- TestScripts/embed_binary has the live check complain about "//go:embed binary_del.bin" with
"binary_del" is misspelled in comment
- My operating assumption is it's a change in AST walking exposing something differently, and my crude ideas for fixing it would cause consequences elsewhere ("just drop //go:embed lines in the text-reader filtering!")
- So I'm drawing it to your attention but not fixing it