korrel8r icon indicating copy to clipboard operation
korrel8r copied to clipboard

Metric and store domains do not respect Constraint.Limit

Open alanconway opened this issue 1 year ago • 2 comments

The metric and alert domains do not respect Constraint.Limit, and can return large amounts of data. They do respect time constraints, but a size limit is needed in case time constraints are set too wide, and even fairly modes time intervals can return a lot of metrics.

Apparently limit parameter is only supported by Prometheus and not yet in Thanos or the alerts API. A possible solution is to read prometheus directly for all metric/alert data.

Note limiting the data inside korrel8r after the request returns isn't sufficient - large queries cause thanos/prometheus to time out and sometimes degrade in performance.

alanconway avatar Aug 06 '24 15:08 alanconway

@simonpasquier FYI

alanconway avatar Aug 06 '24 15:08 alanconway

NOTE: https://github.com/prometheus/client_golang/pull/1544 limits support added to the Prometheus API client Released in: https://github.com/prometheus/client_golang/releases/tag/v1.20.0

alanconway avatar Aug 27 '24 19:08 alanconway