Tolya Korniltsev

Results 207 comments of Tolya Korniltsev

No tests added . Tested manually, example does work

Let's start by allowing users to disable line numbers collection https://github.com/grafana/pyroscope-rs/pull/199 I will then look into the actual issue and see what we can do there.

No, this was not intentional. I'm aware of the fail. This has never happened before. I am bit busy with some other stuff at the moment, and I will be...

@mtralka just fyi: the previous fix was re-released successfully by @ simonswine yesterday Here I'm preparing a proper fix https://github.com/grafana/py-spy/pull/1 for the next release

Yeah, It was fixed in our fork as well a while ago. I will update our fork / get rid of the fork once it is released

I think it makes sense to move this under disableGCRuns checks

This may help or simplify solving https://github.com/grafana/pyroscope-rs/issues/209