kornia icon indicating copy to clipboard operation
kornia copied to clipboard

Added random snow

Open Oleksandra2020 opened this issue 2 years ago โ€ข 2 comments

Changes

Fixes # (issue)

Type of change

  • [ ] ๐Ÿ“š Documentation Update
  • [ ] ๐Ÿงช Tests Cases
  • [ ] ๐Ÿž Bug fix (non-breaking change which fixes an issue)
  • [ ] ๐Ÿ”ฌ New feature (non-breaking change which adds functionality)
  • [ ] ๐Ÿšจ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] ๐Ÿ“ This change requires a documentation update

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] Did you update CHANGELOG in case of a major change?

Oleksandra2020 avatar Jul 24 '22 17:07 Oleksandra2020

@Oleksandra2020 one last comment, are you some visualizing the output of this ? not required for now but worth to include the ops here to get for free visual result in the docs: https://github.com/kornia/kornia/blob/master/docs/generate_example_images.py

edgarriba avatar Jul 27 '22 08:07 edgarriba

@Oleksandra2020 one last comment, are you some visualizing the output of this ? not required for now but worth to include the ops here to get for free visual result in the docs: https://github.com/kornia/kornia/blob/master/docs/generate_example_images.py

I have not seen this before, yes, I will add random snow there.

I also ran the augmentation in this notebook (https://colab.research.google.com/drive/16ffvzhlWbi0mHK3Xa3hUdAWpePZDMCAi?usp=sharing) and compared the output to the albumentations output.

Oleksandra2020 avatar Jul 27 '22 09:07 Oleksandra2020

@Oleksandra2020 Hi, any updates on this?

shijianjian avatar Dec 28 '22 08:12 shijianjian

since we merged #2229, this one can be closed?

johnnv1 avatar Mar 02 '23 21:03 johnnv1