kornia-rs icon indicating copy to clipboard operation
kornia-rs copied to clipboard

use `thiserror` to handle errors

Open edgarriba opened this issue 11 months ago • 4 comments

for now errors are handle with anyhow -- this is good at application level but ideally we should create custom error types for lib development.

ideally use https://github.com/dtolnay/thiserror

edgarriba avatar Mar 09 '24 16:03 edgarriba

Hi @edgarriba I am interested in contributing to this project. How do I get started?

vcode11 avatar Apr 16 '24 08:04 vcode11

@vcode11 thanks for the interest ! if you feel comfortable with Rust and thiserror feel free to go for it

edgarriba avatar Apr 16 '24 08:04 edgarriba

I found your commit: https://github.com/kornia/kornia-rs/commit/d72fca813731e6359201e4f35bce9ffb1fb621df this seems to solve the problem? Any particular reason why you didn't merge this? Anything that is missing here that you would like to have?

vcode11 avatar Apr 17 '24 05:04 vcode11

lack of time to finally land this but feel free to take that diff resume the task. The only thing i was a bit concerned is that i couldn't figure out properly how to chain all the original errors for the integrated library a propagate properly to the high level applications.

edgarriba avatar Apr 20 '24 19:04 edgarriba

implemented in main already

edgarriba avatar Sep 03 '24 22:09 edgarriba