kornia-rs
kornia-rs copied to clipboard
use `thiserror` to handle errors
for now errors are handle with anyhow
-- this is good at application level but ideally we should create custom error types for lib development.
ideally use https://github.com/dtolnay/thiserror
Hi @edgarriba I am interested in contributing to this project. How do I get started?
@vcode11 thanks for the interest ! if you feel comfortable with Rust and thiserror
feel free to go for it
I found your commit: https://github.com/kornia/kornia-rs/commit/d72fca813731e6359201e4f35bce9ffb1fb621df this seems to solve the problem? Any particular reason why you didn't merge this? Anything that is missing here that you would like to have?
lack of time to finally land this but feel free to take that diff resume the task. The only thing i was a bit concerned is that i couldn't figure out properly how to chain all the original errors for the integrated library a propagate properly to the high level applications.
implemented in main already