koreader
Kobo books plugin
This plugin supports the following:
- viewing the list of read, unread, archived and wishlisted Kobo books
- viewing book information (description, language, publication date, publisher name, ISBN, last read date, wishlisting date)
- downloading purchased and Kobo Plus books
Depends on: https://github.com/koreader/koreader-base/pull/2070 https://github.com/koreader/koreader-base/pull/2071
Some screenshots:
This change is 
I don't know if it is appropriate to include this in KOReader or not. :)
Anyway, there is one "major" issue with it right now: the Kobo books menu appears in the main menu after Exit. I could not find a way to move it before other menu entries (for example after Collections). Otherwise everything works.
I don't know if it is appropriate to include this in KOReader or not. :)
It isn't. But looks like a cool project with many potential users. I would suggest to host it somewhere else. Quality projects that do something useful have life on their own and will be reached by interested people :)
I'm not sure if I agree that it isn't appropriate, but I do agree that I don't particularly want to maintain it if Kobo changes their API or something.
Anyway, there is one "major" issue with it right now: the Kobo books menu appears in the main menu after Exit. I could not find a way to move it before other menu entries (for example after Collections). Otherwise everything works.
For core plugins you should edit the menu order directly. sorting_hint is for third-party plugins. Though I suppose while we're discussing whether it should be a core plugin you shouldn't rush to change that. :-)
I'm not sure if I agree that it isn't appropriate, but I do agree that I don't particularly want to maintain it if Kobo changes their API or something.
I agree: it does nothing wrong and it has nothing to do with plugins that promote piracy. It is DeDRM, nonetheless, and decrypts blobs with drm into useful documents. It is probably a break of Rakuten TOS at least and might be non-legal somewhere. IANAL but it looks risky to having the code lying around.
It is DeDRM. It will be popular even if it isn't upstream.
It is DeDRM, nonetheless, and decrypts blobs with drm into useful documents. It is probably a break of Rakuten TOS at least and might be non-legal somewhere.
What do you think about including the plugin without the DRM removal code? I think that is the most risky part in it. It could still download books that do not contain DRM.
I hadn't noticed that, or rather I hadn't looked at the code but I was merely talking about the concept as described in the OP. I assumed it was only for downloading non-DRM EPUBs from Kobo. Or in any case most books I have on Kobo have a DRM-free EPUB download option.
I would agree that DeDRM wouldn't be appropriate here.
It is DeDRM, nonetheless, and decrypts blobs with drm into useful documents. It is probably a break of Rakuten TOS at least and might be non-legal somewhere. IANAL but it looks risky to having the code lying around.
Besides that DeDRM is "source available" only not opensource without proper foss license. Similar to Calibre, better to be served as 3-rd-party plugin?
