koreader icon indicating copy to clipboard operation
koreader copied to clipboard

The reading direction should not be greyed out when fit is set to anything but full in cbz files

Open Danar435 opened this issue 1 year ago • 1 comments

  • KOReader version: 2023.01
  • Device: PB970

Issue

Hi, I use KoReader to primarily read manga, and as you may know, manga is read from right to left. Sometimes there might be double pages, which don't look good scaled to fit on a vertical screen. So I read with fit set to height rather than full and zoom set to the whole page. However when I encounter a double page, it would start from left, and progress to the right. No problem I thought, because you can change the direction, except that it's grayed out when the zoom is set to page. Changing the zoom, then changing the direction, and then changing the zoom again fixes the issue with later double pages, but it remains when I move onto another book.

The easy solution would be to make the direction work even when the zoom is set to page or fit is set to anything but full. Because if fit crops a page, then the direction would always be left to right, top to bottom.

Steps to reproduce

  1. Open a comic or a manga that has connected double pages
  2. Set the fit to height and zoom to page
  3. Upon encountering a double page it'll start from left to right
  4. Change the zoom to something else, then change the direction to right to left
  5. Change the zoom back, next time you encounter a doulbe page it'll be from right to left
  6. Open another book, even though the direction is correctly selected, it'll be grayed out and double pages will be read from left to right

I think the explanation is enough, but let me know if you need any sample files.

Danar435 avatar Mar 19 '23 12:03 Danar435

I'm not in a position to double-check right now, but I think the limitation was implemented to paper over potentially horribly broken behavior ;p.

NiLuJe avatar Mar 19 '23 15:03 NiLuJe