Makefile and CMake style

[Frenzie]

I want to get rid of uppercase commands in the CMake files. It's currently a bit of a hodgepodge with a majority lowercase and I think it negatively affects maintainability (i.e., it takes me more time to scan than I think it should). Cf. https://community.kde.org/Policies/CMake_Coding_Style#Upper.2Flower_casing

Enforcement isn't completely self-evident but cmake-lint would probably do the job for some basic checks, also see https://gitlab.kitware.com/cmake/cmake/issues/17441

On a related note, https://github.com/mrtazz/checkmake exists to do similar things for Makefiles. There's also https://github.com/softprops/mint but at a glance that doesn't seem to do much other than checking if all targets exist.

[Frenzie]

First-pass added in https://github.com/koreader/koreader-base/pull/872.

[benoit-pierre]

Is this still relevant?

[Frenzie]

I wouldn't mind having an autoformatter and/or linter for CMake like https://github.com/yamadapc/cmakefmt in place to keep things consistent.

Its output isn't dissimilar to how you reformatted things. But I'm also fine without.

[benoit-pierre]

This might be more useful: https://github.com/cmake-lint/cmake-lint.

[Frenzie]

Yes, but I wasn't aware it had been forked and continued. :-)