koreader-base
koreader-base copied to clipboard
koreader
Bump giflib to 5.1.9
They killed autoconf (and the people rejoiced!), so this may be quirky on some platforms.
Also, probably breaks win32 build for sure.
This change is 
Also, probably breaks win32 build for sure.
On the plus side, as a whole it's already a bit broken, cf. https://github.com/koreader/koreader/issues/4512.
On the downside, you just made the potential of a potentially relatively simple quick fix more distant. ;-)
That'd take a customized Makefile, as upstream's only left a *nix Makefile ;).
Also, apparently macOS isn't *nix enough, because that's also not supported by the Makefile ;p.
@NiLuJe I haven't yet been able to test if Android builds = Android actually works. Unless we want to live dangerously. :-P
:D. I don't recall anything android specific in the Makefile, so, yeah, might be some surprises ;).
On Tue, Feb 26, 2019, 08:50 Frans de Jonge [email protected] wrote:
@NiLuJe https://github.com/NiLuJe I haven't yet been able to test if Android builds = Android actually works. Unless we want to live dangerously. :-P
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/koreader/koreader-base/pull/832#issuecomment-467333019, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG1Zi2w1gwGvaPRNdsHdNxTKQ_8Tzplks5vROc2gaJpZM4bH8MD .
You know, the Android x86 build actually should be able to run the unit tests without too much trouble. That might be something worth exploring… although since it wouldn't be a real limited Android environment it may not be overly useful.
On another note, Travis CI has apparently started firing employees, which doesn't sound like a good thing: https://blog.steve.fi/experimenting_with_github_actions.html
@NiLuJe It's not very informative, but it's not working.
02-26 20:31:32.089 8186 8186 W KOReader: cannot open document /storage/emulated/0/Download/Rotating_earth_(large).gif frontend/document/picdocument.lua:22: Failed to open image
02-26 20:31:32.189 8186 8186 V KOReader: BG extraction done
Oh, actually it doesn't seem to be working in normal KOReader either? This is supposed to load in PicDocument (i.e., just opening a GIF), isn't it?
Edit: yes, confirmed to be working just fine in the current version.
@NiLuJe Everywhere. By "normal" I mean, um, well, basically anything other than Android.
No functional difference for our purposes I think, but 5.1.7 came out in the meantime. :-P
Yeah, it's just a respin of the release tarball ;).
On Thu, Mar 14, 2019, 10:33 Frans de Jonge [email protected] wrote:
No functional difference for our purposes I think, but 5.1.7 came out in the meantime. :-P
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/koreader/koreader-base/pull/832#issuecomment-472772405, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG1ZqLxVqF_Ko2rGiyfKKEo41Ie5znjks5vWhd1gaJpZM4bH8MD .
Jotting that down here, too, for posterity: 5.1.7 is just a respin of the release tarball, no functional changes.
5.1.9 sounds more relevant, especially about AR: (although I think I saw you switch from c89 to c11 so it might independently have become less relevant?)
Version 5.1.9
=============
The documentation directory now includes an HTMlified version of the
GIF89 standard, and a more detailed description of how LZW compression
is applied to GIFs.
* Address SF bug #129: The latest version of giflib cannot be build on windows.
* Address SF bug #126: Cannot compile giflib using c89
Version 5.1.8
=============
* Address SF bug #119: MemorySanitizer: FPE on unknown address
* Address SF bug #125: 5.1.7: xmlto is still required for tarball
* Address SF bug #124: 5.1.7: ar invocation is not crosscompile compatible
* Address SF bug #122: 5.1.7 installs manpages to wrong directory
* Address SF bug #121: make: getversion: Command not found
* Address SF bug #120: 5.1.7 does not build a proper library - no
I dunno, "does not build a proper library" may not be quite the same as "doesn't build". :-)
@NiLuJe Out of boredom, checked this one too, 2 newer small versions available:
Version 5.2.1
==============
This is the "Maybe I shouldn't have dome a release while imn surgical recovery" release.
* In gifbuild.c, avoid a core dump on no color map.
* Restore inadvertently removed library version numbers in Makefile.
Version 5.2.0
=============
The undocumented and deprecated GifQuantizeBuffer() entry point
has been moved to the util library to reduce libgif size and attack
surface. Applications needing this function are couraged to link the
util library or make their own copy.
The following obsolete utility programs are no longer installed:
gifecho, giffilter, gifinto, gifsponge. These were either installed in
error or have been obsolesced by modern image-transformmation tools
like ImageMagick convert. They may be removed entirely in a future
release.
* Address SourceForge issue #136: Stack-buffer-overflow in gifcolor.c:84
* Address SF bug #134: Giflib fails to slurp significant number of gifs
* Apply SPDX convention for license tagging.
Unfortunately still lacking an actual buildsystem allowing us to build it on non-Linux platforms ;).
New patchfile for 5.2.1:
diff --git a/Makefile b/Makefile
index 767c73a..4485f97 100644
--- a/Makefile
+++ b/Makefile
@@ -61,7 +61,6 @@ UTILS = $(INSTALLABLE) \
LDLIBS=libgif.a -lm
all: libgif.so libgif.a $(UTILS)
- $(MAKE) -C doc
$(UTILS):: libgif.a
@@ -82,7 +81,7 @@ check: all
# Installation/uninstallation
-install: all install-bin install-include install-lib install-man
+install: all install-bin install-include install-lib
install-bin: $(INSTALLABLE)
$(INSTALL) -d "$(DESTDIR)$(BINDIR)"
$(INSTALL) $^ "$(DESTDIR)$(BINDIR)"
