koreader-base icon indicating copy to clipboard operation
koreader-base copied to clipboard

generic linux package

Open pazos opened this issue 2 years ago • 2 comments

  • remove soft-float arm32 variant

  • use LINUX_ARCH for cross compilation (supported are arm and arm64)

  • if LINUX_ARCH is not arm or arm64 we assume native compilation. It should work fine on all of the supported targets but only was tested against a 64 bit host.


This change is Reviewable

pazos avatar Jul 19 '22 15:07 pazos

@pazos Was this ready to be merged? It looks sane enough to me.

Also pinging @benoit-pierre

Frenzie avatar May 03 '24 16:05 Frenzie

Fix for turbo LUA files permissions:

 thirdparty/turbo/CMakeLists.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git i/thirdparty/turbo/CMakeLists.txt w/thirdparty/turbo/CMakeLists.txt
index c99f07d5..61e4f48d 100644
--- i/thirdparty/turbo/CMakeLists.txt
+++ w/thirdparty/turbo/CMakeLists.txt
@@ -10,6 +10,9 @@ assert_var_defined(LDFLAGS)
 
 ep_get_source_dir(SOURCE_DIR)
 
+# Some of the LUA files are executables for no good reason.
+list(APPEND PATCH_CMD COMMAND chmod a-x turbo/platform.lua turbo/socket_ffi.lua turbo/syscall.lua)
+
 set(BUILD_CMD ${KO_MAKE_RECURSIVE} "CC=${CC}" "CFLAGS=${CFLAGS}" "LDFLAGS=${LDFLAGS}" all)
 
 # Drop duplicate cdefs, make sure turbo find its libtffi_wrap library, and pull in upstream fixes

benoit-pierre avatar May 06 '24 22:05 benoit-pierre

LGTM.

benoit-pierre avatar May 11 '24 18:05 benoit-pierre