kindlepdfviewer icon indicating copy to clipboard operation
kindlepdfviewer copied to clipboard

All history of current session will lost when program crashed

Open dracodoc opened this issue 11 years ago • 5 comments

Kpv (v2013.1-85-g01c9580) crashed today in my Kindle DX and I don't know why, the crash.log is empty. Then I found all the bookmarks I made in the whole kpv session was gone, which was several days' read.

It's rare that kpv crashed on me, but the lost is still significant. I think the bookmarks or reading history should be written to files at least when the book is closed.

dracodoc avatar Aug 18 '13 23:08 dracodoc

so sorry about that, this is frustrating :(

we should maybe even force a document write whenever user add a bookmark, highlight or other settings.

houqp avatar Aug 19 '13 04:08 houqp

Document write? What do you mean? I assume you mean the document's history file write because that is where bookmarks, highlights and settings are kept. The document itself is never opened except in read only mode.

tigran123 avatar Aug 19 '13 09:08 tigran123

I think that OP means on document close. I agree with @houqp that it should be after user interaction. I've seen similar behavior in koreader, and I would love to implement it, but I don't have any free cycles right now.

dpavlin avatar Aug 19 '13 12:08 dpavlin

Of course if there is no performance penalty, forcing history file write after every user interaction (adding bookmarks etc) will be the best.

dracodoc avatar Aug 19 '13 14:08 dracodoc

FYI, I am working on this now, but kindlepdfviewer is broken now because of recent updates in kroeader-base. I will send out a PR tmr to update API calls first.

To be honest, I have been suffering from this for a long time as well, since I am always using the unstable dev build ;p

houqp avatar Aug 20 '13 05:08 houqp