android-luajit-launcher icon indicating copy to clipboard operation
android-luajit-launcher copied to clipboard

Bottom space missing when using camera notch space in my Oppo with ColorOS

Open jospalau opened this issue 2 years ago • 5 comments

After trying to use the camera notch space in my Oppo: Screenshot_2022-09-26-20-35-08-52_fc704e6b13c4fb26bf5e411f75da84f2.jpg

The bottom is missing: Screenshot_2022-09-26-20-32-11-08_1aff61e6bd981aaa4ba9d0245eb6c04f.jpg

Missbehaving when turning pages: Screenshot_2022-09-26-20-41-48-65_1aff61e6bd981aaa4ba9d0245eb6c04f.jpg

I tried the same in a Galaxy S22 Ultra and it works well. My oppo is running ColorOS 11

jospalau avatar Sep 26 '22 17:09 jospalau

ColorOS is not that useful. Is this android 13?

pazos avatar Sep 26 '22 18:09 pazos

ColorOS is not that useful. Is this android 13?

11 according to the specs: Screenshot_2022-09-26-21-22-07-63_fc704e6b13c4fb26bf5e411f75da84f2.jpg

jospalau avatar Sep 26 '22 18:09 jospalau

mmm...

Does it work fine with autoadapt?

I hope so.

We're not using android view hierarchy and require a rectangle to draw to. We usually get one just discarding a few pixels, as reported by android itself with their safeInsets.

Hint: if it doesn't work in autoadapt or any other mode and you still want to workaround it please attach a picture of the phone to see how it looks, not a screenshot.

pazos avatar Sep 26 '22 18:09 pazos

mmm...

Does it work fine with autoadapt?

I hope so.

We're not using android view hierarchy and require a rectangle to draw to. We usually get one just discarding a few pixels, as reported by android itself with their safeInsets.

Hint: if it doesn't work in autoadapt or any other mode and you still want to workaround it please attach a picture of the phone to see how it looks, not a screenshot.

Autoadapt is by default and by default notch space is black in KOReader and all apps. This is how it looks the phone enabling the notch space and when turning pages the black space down shows/disappears but the text never makes it to the bottom.

20220926_214044.jpg

20220926_214050.jpg

jospalau avatar Sep 26 '22 18:09 jospalau

yeah, we cannot fix that programatically. Use autoadapt.

~~I guess you can workaround it with a viewport but I cannot help that much with runtime patches. Feel free to open a discussion in https://github.com/koreader/koreader/discussions.~~

NVM, It isn't going to work the way intended. It is still reporting the same height and we just have the rectangle a few pixels above. So it ends a few pixels earlier.

pazos avatar Sep 26 '22 19:09 pazos