kord icon indicating copy to clipboard operation
kord copied to clipboard

Migrated Snowflake to inline class

Open zTrap opened this issue 2 years ago • 4 comments

Mockk does not yet supported good boxing\unboxing for inline classes. So most equality check related tests are broken

zTrap avatar Oct 24 '23 00:10 zTrap

Is there an issue already for the problems with mockk?

lukellmann avatar Oct 24 '23 16:10 lukellmann

I've got wrong. This problem isn't related to inline classes, but to unsigned numbers. https://github.com/mockk/mockk/issues/544

zTrap avatar Oct 24 '23 16:10 zTrap

I've got wrong. This problem isn't related to inline classes, but to unsigned numbers. mockk/mockk#544

the issue you pointed to is now closed, is there any update on this?

lukellmann avatar Jan 31 '24 21:01 lukellmann

Yes, issue is closed, but it's not released yet

zTrap avatar Feb 01 '24 00:02 zTrap

@lukellmann seems like all works fine with mockk v1.13.11

zTrap avatar May 29 '24 12:05 zTrap

I'd like to discuss this some more before deciding what to do with this, see https://discord.com/channels/556525343595298817/1245773750486438060

lukellmann avatar May 30 '24 16:05 lukellmann

i've updated the target branch btw

lukellmann avatar Jun 04 '24 09:06 lukellmann

these changes can be tested using experiments-inline-value-classes-SNAPSHOT

lukellmann avatar Jun 05 '24 07:06 lukellmann