Lavalink.kt icon indicating copy to clipboard operation
Lavalink.kt copied to clipboard

Continue adding node even if checks fail

Open freyacodes opened this issue 2 years ago • 3 comments

Perhaps you have a more elaborate strategy in mind. This is enough to do the trick for me at least.

freyacodes avatar Oct 17 '23 09:10 freyacodes

Fixes #32

freyacodes avatar Oct 17 '23 09:10 freyacodes

I am not sure whether this is the right call, since the version check should stop connecting to the node, maybe we can move it to after the ws connect, however that wouldn't be ideal either. Maybe add a config flag for it?

DRSchlaubi avatar Oct 17 '23 10:10 DRSchlaubi

It didn't occur to me it throws an exception on purpose. What you could do is apply the same retry strategy to the version check

I think you should also put some thought into what happens if a node is rejected. Currently if a node is rejected, it just seems to linger in an inactive state in the AbstractLavakord instance.

freyacodes avatar Oct 17 '23 11:10 freyacodes