steam-condenser icon indicating copy to clipboard operation
steam-condenser copied to clipboard

Published 20 hours ago • verified publisher icon koraktor

toString methods

Open ZeroOne3010 opened this issue 10 years ago • 8 comments

In the Java version, please add proper toString methods to some key classes (such as GameAchievement, SteamGame and GameStats) in order to facilitate testing and prototyping.

ZeroOne3010 avatar Nov 25 '13 00:11 ZeroOne3010

I've created pull request number 10 for this one.

ZeroOne3010 avatar Nov 25 '13 00:11 ZeroOne3010

@koraktor Is this issue closed? Need any additional help here?

gcoelho avatar Feb 24 '14 15:02 gcoelho

No, this is still open, although koraktor/steam-condenser-java#10 has been merged, but there are plenty of other classes that could use some improvement here.

And additionally, the other implementations could use the same enhancements.

koraktor avatar Feb 24 '14 15:02 koraktor

Ok, I will work on this issue. Any classes you want me to take a look first?

gcoelho avatar Feb 25 '14 12:02 gcoelho

Well, it's would be most useful to have it for the "front-end" classes, like the servers, GameLeaderboard and inventories.

koraktor avatar Feb 26 '14 07:02 koraktor

@koraktor What code format standard do you use? I am asking to use the same while adding this methods. If possible, can you share this config file to be imported?

gcoelho avatar Feb 27 '14 16:02 gcoelho

@gcoelho There's no codystyle.xml or similar, but there's a CONTRIBUTING file for each implementation and you should follow the conventions in there.

koraktor avatar Feb 27 '14 19:02 koraktor

Ok, thanks! :+1:

I just did a commit for GameLeaderboard and Servers. Inventories classes don´t have a test class so I will create some tests too on a future commit.

If you want to take a look: gcoelho/steam-condenser-java@d8379f558d9d27a1a99735dcd70050939a18f0b3

I wiil keep working on this issue to include Inventories.

gcoelho avatar Feb 27 '14 20:02 gcoelho