Oliver Kopp
Oliver Kopp
On [`0a33b34` (#11430)](https://github.com/JabRef/jabref/pull/11430/commits/0a33b343a3532855013411ca6d02e9d5dea8c640), I radically simplified BibChatHistoryManager. Also added a test case BibChatHistoryManagerTest. Feel free to refine the test.
I tried to revert "Add workaround to get FileHistoryMenuTest running again" (commit 8ec3876c737f0144e337c397037290104f3701ed), but did not succeed - still the mockito error.
@CXZHANG0508 I will do. Meanwhile, I will use this issue and PR https://github.com/JabRef/jabref/pull/14578 as test for our automation actions.
/assign @CXZHANG0508
> > > The threading thing looks complicated. There at least should be a note why a "synchronous" nested thread-spawning thing is nested in a Background-Task. > > > Not...
@InAnYan Thank you for pointing out. Your code should solve the issue. @st-rm-ng Please incorporate that idea into your solution!
@st-rm-ng please request a review **after** all tests go through (or ask for help if you tried hard to fix tests and you did not manage). Thank you.
> @koppor I've fixed all GitHub checks, but I still can't pass those 13 Unit tests when creating full local build As long as they run on GitHub, it should...
@st-rm-ng Any interest to continue here or should we free this issue for another contributor?
> Currently no user-visible change, is it?\n\nI think, the model list in the preferences should be updated, shouldn't hey? Did I miss something? @st-rm-ng what's the answer for that?