koordinator
koordinator copied to clipboard
koordlet: unset cfs_quota for LSR/LSE pods
Signed-off-by: saintube [email protected]
Ⅰ. Describe what this PR does
unset pod-level and container-level cgroup cpu.cfs_quota_us
for cpuset pods (qos=LSR/LSE) to avoid unnecessary throttles
Ⅱ. Does this pull request fix one issue?
fixes #489
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
- [X] I have written necessary docs and comments
- [x] I have added necessary unit tests and integration tests
- [X] All checks passed in
make test
Codecov Report
Base: 68.92% // Head: 68.81% // Decreases project coverage by -0.10%
:warning:
Coverage data is based on head (
ddb82fe
) compared to base (e088c63
). Patch coverage: 46.80% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 68.92% 68.81% -0.11%
==========================================
Files 203 204 +1
Lines 22928 23007 +79
==========================================
+ Hits 15802 15833 +31
- Misses 6031 6076 +45
- Partials 1095 1098 +3
Flag | Coverage Δ | |
---|---|---|
unittests | 68.81% <46.80%> (-0.11%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/koordlet/metricsadvisor/collector.go | 9.53% <0.00%> (ø) |
|
pkg/koordlet/resmanager/cgroup_reconcile.go | 86.36% <0.00%> (ø) |
|
...oordlet/runtimehooks/protocol/container_context.go | 10.00% <0.00%> (-1.60%) |
:arrow_down: |
pkg/koordlet/runtimehooks/protocol/pod_context.go | 12.30% <0.00%> (-2.24%) |
:arrow_down: |
pkg/koordlet/runtimehooks/protocol/protocol.go | 5.88% <0.00%> (-1.27%) |
:arrow_down: |
pkg/util/pod.go | 52.60% <33.33%> (-1.06%) |
:arrow_down: |
pkg/util/pod_qos_utils.go | 33.33% <33.33%> (ø) |
|
pkg/koordlet/runtimehooks/hooks/cpuset/cpuset.go | 70.37% <82.92%> (+7.32%) |
:arrow_up: |
pkg/koordlet/resmanager/cpu_burst.go | 76.29% <100.00%> (-0.06%) |
:arrow_down: |
pkg/runtimeproxy/resexecutor/cri/utils.go | 89.56% <100.00%> (ø) |
|
... and 1 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hormes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hormes]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment