koordinator
koordinator copied to clipboard
koord-manager: modify quota-webhook
Signed-off-by: xulinfei.xlf [email protected]
Ⅰ. Describe what this PR does
The main purpose is to reorganize the InjectCache function of the webhooks, only allow validate-quota to addEventHandlers.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests
- [ ] All checks passed in
make test
Codecov Report
Base: 68.77% // Head: 68.76% // Decreases project coverage by -0.01%
:warning:
Coverage data is based on head (
6817175
) compared to base (24d7291
). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 68.77% 68.76% -0.02%
==========================================
Files 204 204
Lines 23008 22954 -54
==========================================
- Hits 15824 15784 -40
+ Misses 6080 6070 -10
+ Partials 1104 1100 -4
Flag | Coverage Δ | |
---|---|---|
unittests | 68.76% <100.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
.../webhook/elasticquota/mutating/mutating_handler.go | 81.57% <ø> (-2.30%) |
:arrow_down: |
pkg/webhook/elasticquota/quota_topology_check.go | 73.78% <ø> (-0.32%) |
:arrow_down: |
...hook/elasticquota/validating/validating_handler.go | 74.13% <ø> (-2.06%) |
:arrow_down: |
pkg/webhook/pod/validating/validating_handler.go | 82.85% <ø> (-1.89%) |
:arrow_down: |
pkg/webhook/elasticquota/quota_topology.go | 83.65% <100.00%> (+0.15%) |
:arrow_up: |
pkg/scheduler/plugins/elasticquota/controller.go | 76.00% <0.00%> (+10.66%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: buptcozy, eahydra, hormes, jasonliu747
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hormes]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment