koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

making code easier to read

Open lucming opened this issue 2 years ago • 4 comments

Signed-off-by: lucming [email protected]

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

lucming avatar Sep 22 '22 06:09 lucming

Codecov Report

Base: 68.87% // Head: 68.78% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (83d8b7f) compared to base (8642578). Patch coverage: 73.52% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   68.87%   68.78%   -0.09%     
==========================================
  Files         203      204       +1     
  Lines       22906    22959      +53     
==========================================
+ Hits        15776    15793      +17     
- Misses       6031     6067      +36     
  Partials     1099     1099              
Flag Coverage Δ
unittests 68.78% <73.52%> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/elasticquota/preempt.go 40.72% <16.66%> (-0.74%) :arrow_down:
...eduler/plugins/coscheduling/controller/podgroup.go 74.37% <41.66%> (+1.95%) :arrow_up:
...kg/scheduler/plugins/elasticquota/plugin_helper.go 78.57% <85.71%> (-0.78%) :arrow_down:
pkg/scheduler/plugins/deviceshare/device_cache.go 86.57% <100.00%> (ø)
.../webhook/elasticquota/mutating/mutating_handler.go 81.57% <0.00%> (-2.30%) :arrow_down:
pkg/koordlet/runtimehooks/protocol/pod_context.go 12.30% <0.00%> (-2.24%) :arrow_down:
...hook/elasticquota/validating/validating_handler.go 74.13% <0.00%> (-2.06%) :arrow_down:
pkg/webhook/pod/validating/validating_handler.go 82.85% <0.00%> (-1.89%) :arrow_down:
...oordlet/runtimehooks/protocol/container_context.go 10.00% <0.00%> (-1.60%) :arrow_down:
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 22 '22 06:09 codecov[bot]

Hi @lucming thanks for your contribution. Are you interested in improving our entire logging? For more details, you may check #210.

jasonliu747 avatar Sep 22 '22 12:09 jasonliu747

/lgtm cancel

jasonliu747 avatar Sep 30 '22 01:09 jasonliu747

/approve

hormes avatar Oct 24 '22 04:10 hormes

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Oct 24 '22 04:10 koordinator-bot[bot]