koordinator
koordinator copied to clipboard
code collation
…les in the preemption plugin
Ⅰ. Describe what this PR does
- optimise the handling of error
- optimise the initialisation logic of variables in the preemption plugin
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests
- [ ] All checks passed in
make test
Codecov Report
Base: 68.81% // Head: 68.89% // Increases project coverage by +0.07%
:tada:
Coverage data is based on head (
c9a5a79
) compared to base (62f57b6
). Patch coverage: 47.82% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 68.81% 68.89% +0.07%
==========================================
Files 196 203 +7
Lines 22322 22900 +578
==========================================
+ Hits 15360 15776 +416
- Misses 5886 6029 +143
- Partials 1076 1095 +19
Flag | Coverage Δ | |
---|---|---|
unittests | 68.89% <47.82%> (+0.07%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...cheduler/plugins/reservation/garbage_collection.go | 82.01% <47.05%> (-0.13%) |
:arrow_down: |
.../plugins/compatibledefaultpreemption/preemption.go | 85.36% <50.00%> (+4.93%) |
:arrow_up: |
pkg/webhook/pod/validating/validating_handler.go | 84.74% <0.00%> (-5.26%) |
:arrow_down: |
pkg/util/resource.go | 45.45% <0.00%> (-4.55%) |
:arrow_down: |
...r/plugins/elasticquota/core/group_quota_manager.go | 84.33% <0.00%> (-2.30%) |
:arrow_down: |
pkg/koordlet/resmanager/memory_evict.go | 69.82% <0.00%> (-2.25%) |
:arrow_down: |
pkg/koordlet/statesinformer/states_device_linux.go | 42.40% <0.00%> (-0.68%) |
:arrow_down: |
...kg/scheduler/plugins/elasticquota/plugin_helper.go | 79.34% <0.00%> (-0.44%) |
:arrow_down: |
pkg/slo-controller/nodeslo/resource_strategy.go | 84.61% <0.00%> (-0.14%) |
:arrow_down: |
... and 14 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: eahydra, hormes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hormes]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment