koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

Qos manager framework

Open stormgbs opened this issue 3 years ago • 3 comments

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

stormgbs avatar Sep 08 '22 10:09 stormgbs

Codecov Report

Base: 68.95% // Head: 68.71% // Decreases project coverage by -0.24% :warning:

Coverage data is based on head (94c082b) compared to base (d1811e5). Patch coverage: 40.83% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/qos-manager     #602      +/-   ##
====================================================
- Coverage             68.95%   68.71%   -0.25%     
====================================================
  Files                   178      181       +3     
  Lines                 20847    21038     +191     
====================================================
+ Hits                  14376    14457      +81     
- Misses                 5478     5589     +111     
+ Partials                993      992       -1     
Flag Coverage Δ
unittests 68.71% <40.83%> (-0.25%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/qosmanager/manager.go 0.00% <0.00%> (ø)
pkg/koordlet/config/config.go 48.21% <22.22%> (-24.20%) :arrow_down:
.../koordlet/qosmanager/metricsquery/metrics_query.go 57.54% <57.54%> (ø)
pkg/koordlet/qosmanager/config/config.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) :arrow_down:
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) :arrow_up:
...eduler/plugins/coscheduling/controller/podgroup.go 72.41% <0.00%> (+1.47%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 08 '22 10:09 codecov[bot]

/lgtm

zwzhang0107 avatar Sep 09 '22 08:09 zwzhang0107

/lgtm

zwzhang0107 avatar Oct 11 '22 07:10 zwzhang0107

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Oct 19 '22 03:10 koordinator-bot[bot]

/lgtm

hormes avatar Oct 19 '22 03:10 hormes