koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

feature: report gpu resource

Open ZYecho opened this issue 2 years ago • 3 comments

Signed-off-by: Yue Zhang [email protected]

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #381

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

ZYecho avatar Jul 26 '22 11:07 ZYecho

/cc @LambdaHJ

jasonliu747 avatar Jul 26 '22 12:07 jasonliu747

Codecov Report

Merging #410 (5b1ce9d) into main (779ac80) will increase coverage by 0.05%. The diff coverage is 46.69%.

:exclamation: Current head 5b1ce9d differs from pull request most recent head f549ba6. Consider uploading reports for the commit f549ba6 to get more accurate results

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   66.18%   66.23%   +0.05%     
==========================================
  Files         119      120       +1     
  Lines       12136    12157      +21     
==========================================
+ Hits         8032     8052      +20     
  Misses       3477     3477              
- Partials      627      628       +1     
Flag Coverage Δ
unittests 66.23% <46.69%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metricsadvisor/collector_gpu.go 0.00% <ø> (-34.62%) :arrow_down:
pkg/koordlet/metricsadvisor/collector_gpu_linux.go 36.84% <36.84%> (ø)
pkg/koordlet/runtimehooks/hooks/cpuset/cpuset.go 64.44% <75.00%> (-0.78%) :arrow_down:
pkg/koordlet/runtimehooks/hooks/cpuset/rule.go 93.40% <88.23%> (-2.43%) :arrow_down:
pkg/slo-controller/config/config.go 91.80% <100.00%> (+0.42%) :arrow_up:
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 779ac80...f549ba6. Read the comment docs.

codecov[bot] avatar Jul 27 '22 12:07 codecov[bot]

@caohe you might be interested in checking this PR

jasonliu747 avatar Aug 18 '22 11:08 jasonliu747

Please also create a pull request to update RBAC accordingly in this repo https://github.com/koordinator-sh/charts. Thanks.

jasonliu747 avatar Sep 01 '22 02:09 jasonliu747

/lgtm /approve

hormes avatar Sep 02 '22 03:09 hormes

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, LambdaHJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Sep 02 '22 03:09 koordinator-bot[bot]