koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

scheduler: elastic quota ignore terminating pod immediately

Open TaoYang526 opened this issue 1 year ago • 8 comments

Ⅰ. Describe what this PR does

proposal: #2179 introduce a feature gate called ElasticQuotaImmediateIgnoreTerminatingPod, which would allow to bypass the deletion grace period and immediately ignore terminating pods.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

TaoYang526 avatar Aug 29 '24 02:08 TaoYang526

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.69%. Comparing base (e15a68c) to head (76c2248). Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2180      +/-   ##
==========================================
- Coverage   67.69%   67.69%   -0.01%     
==========================================
  Files         446      446              
  Lines       42686    42688       +2     
==========================================
- Hits        28898    28896       -2     
- Misses      11269    11272       +3     
- Partials     2519     2520       +1     
Flag Coverage Δ
unittests 67.69% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 29 '24 02:08 codecov[bot]

@TaoYang526 Thanks for your contributions! Before the PR gets reviewed, please fix the DCO check for your commits. https://github.com/koordinator-sh/koordinator/pull/2180/checks?check_run_id=29400771605

saintube avatar Aug 29 '24 09:08 saintube

@saintube Thanks for reminding that, just updated.

TaoYang526 avatar Aug 29 '24 10:08 TaoYang526

/retest

TaoYang526 avatar Aug 30 '24 00:08 TaoYang526

@TaoYang526: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

koordinator-bot[bot] avatar Aug 30 '24 00:08 koordinator-bot[bot]

/ok-to-test /retest

saintube avatar Aug 30 '24 04:08 saintube

/lgtm PTAL /cc @shaloulcy @ZiMengSheng @hormes

saintube avatar Aug 30 '24 04:08 saintube

/lgtm /approve

hormes avatar Sep 02 '24 03:09 hormes

/lgtm /approve

hormes avatar Sep 02 '24 05:09 hormes

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Sep 02 '24 05:09 koordinator-bot[bot]

Thanks @hormes @saintube for the review and commit.

TaoYang526 avatar Sep 03 '24 01:09 TaoYang526