koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

[proposal] Coscheduling move some BeforePreFilter quick check into PreEnqueueExtension

Open ZiMengSheng opened this issue 1 year ago • 5 comments

What is your proposal: Coscheduling currently checks whether the member Pods of the Gang have reached the Minmember number and whether the Gang has been initialized. K8s 1.28 brings the prequeue extension interface, which can determine whether the conditions for joining the queue are met before the Pod joins ActiveQ. So we can consider putting some Gang checks in PreEnqueue.

Why is this needed:

reduce wasty scheduling cycle.

Is there a suggested solution, if so, please add it:

ZiMengSheng avatar Jul 24 '24 09:07 ZiMengSheng

/assign AdrianMachao

ZiMengSheng avatar Jul 24 '24 12:07 ZiMengSheng

@ZiMengSheng: GitHub didn't allow me to assign the following users: AdrianMachao.

Note that only koordinator-sh members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign AdrianMachao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

koordinator-bot[bot] avatar Jul 24 '24 12:07 koordinator-bot[bot]

/assign

AdrianMachao avatar Jul 24 '24 12:07 AdrianMachao

Can you update this picture?

https://github.com/koordinator-sh/koordinator/blob/main/docs/images/koord-scheduler-framework-ext.png

hormes avatar Aug 08 '24 04:08 hormes

Can you update this picture?

https://github.com/koordinator-sh/koordinator/blob/main/docs/images/koord-scheduler-framework-ext.png

Got it

AdrianMachao avatar Aug 08 '24 05:08 AdrianMachao