koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

scheduler: improve gang log

Open googs1025 opened this issue 1 year ago • 9 comments

Ⅰ. Describe what this PR does

I modified the current log level output method. In order to reduce log printing, I only print when --v=4 is used, and use klog.V().ErrorS for the err!=nil part.

Ⅱ. Does this pull request fix one issue?

fix: https://github.com/koordinator-sh/koordinator/issues/1895#issuecomment-2060218803

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

googs1025 avatar Apr 17 '24 04:04 googs1025

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.70%. Comparing base (e15a68c) to head (298ae4c). Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   67.69%   67.70%           
=======================================
  Files         446      446           
  Lines       42686    42686           
=======================================
+ Hits        28898    28899    +1     
+ Misses      11269    11265    -4     
- Partials     2519     2522    +3     
Flag Coverage Δ
unittests 67.70% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 17 '24 04:04 codecov[bot]

@buptcozy @eahydra /PTAL

googs1025 avatar Apr 17 '24 12:04 googs1025

Why do we need to downgrade error logs to V4?

hormes avatar Apr 28 '24 07:04 hormes

Why do we need to downgrade error logs to V4?

Indeed, this level needs to be confirmed. However, setting the log level can effectively reduce the number of log prints.

googs1025 avatar Apr 30 '24 08:04 googs1025

/assign @ZiMengSheng

jasonliu747 avatar May 21 '24 11:05 jasonliu747

/lgtm

ZiMengSheng avatar Aug 05 '24 13:08 ZiMengSheng

Sorry for being late. I've been busy with other work recently. I'll go through the comments and make some revisions during the holidays.

googs1025 avatar Aug 06 '24 00:08 googs1025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Sep 02 '24 02:09 koordinator-bot[bot]

New changes are detected. LGTM label has been removed.

koordinator-bot[bot] avatar Sep 02 '24 04:09 koordinator-bot[bot]