koordinator
koordinator copied to clipboard
koordlet: add resctrl qos collector
Ⅰ. Describe what this PR does
Add resctrl qos collector.
Ⅱ. Does this pull request fix one issue?
fixes #1832
Ⅲ. Describe how to verify it
After enable resctrl flag in config:
curl http://localhost:9316/metrics|grep resctrl
Ⅳ. Special notes for reviews
V. Checklist
- [x] I have written necessary docs and comments
- [x] I have added necessary unit tests and integration tests
- [x] All checks passed in
make test
Codecov Report
Attention: Patch coverage is 54.09253% with 129 lines in your changes missing coverage. Please review.
Project coverage is 65.96%. Comparing base (
83267af) to head (6050553). Report is 96 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
- Coverage 67.19% 65.96% -1.23%
==========================================
Files 451 461 +10
Lines 43468 54190 +10722
==========================================
+ Hits 29208 35747 +6539
- Misses 11714 15876 +4162
- Partials 2546 2567 +21
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 65.96% <54.09%> (-1.23%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Sorry for the late pr, any comments is welcome.
hello, PTAL 😊 @saintube
@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.
@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.
😊 Anything I can do?
@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.
😊 Anything I can do?
We will verify this patch on some test environments later. It would also be appreciated if you could add more UTs to increase the patch coverage to no less than the target of 70%.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: saintube, zwzhang0107
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/features/OWNERS~~ [zwzhang0107]
- ~~pkg/koordlet/OWNERS~~ [saintube,zwzhang0107]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment