koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

koordlet: support blkio-cost user cost model configuration

Open wangxiaoq opened this issue 11 months ago • 3 comments

Ⅰ. Describe what this PR does

support blkio-cost user model configuration, see https://www.alibabacloud.com/help/en/alinux/user-guide/configure-the-weight-based-throttling-feature-of-blk-iocost

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

  1. configure enableUserModel: true and other user cost model parameters in resource-qos-config
  2. Verify the content of /sys/fs/cgroup/blkio/blkio.cost.model file on the k8s node

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

wangxiaoq avatar Mar 07 '24 08:03 wangxiaoq

Codecov Report

Attention: Patch coverage is 64.40678% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 67.52%. Comparing base (36ad576) to head (25dd677). Report is 4 commits behind head on main.

Files Patch % Lines
...ordlet/qosmanager/plugins/blkio/blkio_reconcile.go 78.72% 9 Missing and 1 partial :warning:
pkg/koordlet/util/system/validator.go 0.00% 10 Missing :warning:
pkg/koordlet/resourceexecutor/updater.go 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1942      +/-   ##
==========================================
- Coverage   67.52%   67.52%   -0.01%     
==========================================
  Files         420      420              
  Lines       46957    47010      +53     
==========================================
+ Hits        31710    31745      +35     
- Misses      12938    12957      +19     
+ Partials     2309     2308       -1     
Flag Coverage Δ
unittests 67.52% <64.40%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 07 '24 08:03 codecov[bot]

/lgtm

zwzhang0107 avatar Mar 08 '24 08:03 zwzhang0107

/lgtm

saintube avatar Mar 11 '24 07:03 saintube

/approve

hormes avatar Mar 13 '24 04:03 hormes

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Mar 13 '24 04:03 koordinator-bot[bot]