koordinator
koordinator copied to clipboard
koordlet: support blkio-cost user cost model configuration
Ⅰ. Describe what this PR does
support blkio-cost user model configuration, see https://www.alibabacloud.com/help/en/alinux/user-guide/configure-the-weight-based-throttling-feature-of-blk-iocost
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
- configure
enableUserModel: true
and other user cost model parameters in resource-qos-config - Verify the content of /sys/fs/cgroup/blkio/blkio.cost.model file on the k8s node
Ⅳ. Special notes for reviews
V. Checklist
- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests
- [ ] All checks passed in
make test
Codecov Report
Attention: Patch coverage is 64.40678%
with 21 lines
in your changes are missing coverage. Please review.
Project coverage is 67.52%. Comparing base (
36ad576
) to head (25dd677
). Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1942 +/- ##
==========================================
- Coverage 67.52% 67.52% -0.01%
==========================================
Files 420 420
Lines 46957 47010 +53
==========================================
+ Hits 31710 31745 +35
- Misses 12938 12957 +19
+ Partials 2309 2308 -1
Flag | Coverage Δ | |
---|---|---|
unittests | 67.52% <64.40%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hormes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~apis/OWNERS~~ [hormes]
- ~~config/OWNERS~~ [hormes]
- ~~pkg/koordlet/OWNERS~~ [hormes]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment